Repository navigation
feat(snmp): poll shiva over SNMPv3 authPriv (#85) - #581
Merged
Merged
Conversation
The repository half of the iLO's move, per ADR-0036 and runbook §4: auth_ilo becomes the authPriv block (SHA, AES, user `prometheus`), snmp.yaml is regenerated from it, and the two plaintext copies of the key list — render-config.sh's REQUIRED array and the example secrets file — carry SNMP_AUTHPASS_ILO and SNMP_PRIVPASS_ILO in place of the community. The sops change is its own commit. One thing the dry run of #431 could not see, because every block was still v2c: the generator fills every unset auth field from its defaults, and its default community is the stock string, so a v3 block with no community line comes out of `make snmp-generate` carrying that string beside the USM user — and gitleaks' community rule, correctly, fails validate on the generated file. An explicit empty string is marshalled with omitempty and the line is dropped. `snmp-targets.sh --check` now requires that empty string in a v3 block and refuses anything else, and the three documented copies of the v3 shape show it. Docs record the iLO as polled over v3 from 2026-09-20 and leave the SNMPv1 switch-off to the issue until it is proved with `--old`. The switch half of #85 is gone: ADR-0041 commissions the CRS326 with a v3 user by the same runbook, so the MokerLink's UI is not checked for one. Refs #85 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
SNMP_COMMUNITY_ILO out, SNMP_AUTHPASS_ILO and SNMP_PRIVPASS_ILO in. The user was created on the iLO first, and `snmp-verify.sh --device shiva` passed over SNMPv3 from this branch before this commit. Refs #85 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Gerrrt
force-pushed
the
gerrrt/snmpv3-ilo-ups-authpriv-76f804
branch
from
September 20, 2026 22:18
f04caad to
a33a3a3
Compare
This was referenced Sep 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first of the two device moves ADR-0036 decided, and the first pass of runbook §4 against a real device. Refs #85 —
mjolnirfollows on its own PR, and the issue closes with it.Device first
The
prometheususer exists onshiva(SHA, AES) as of today, with SNMPv1 Request still enabled: the community is the rollback credential until the v3 poll is live from the stack. From this branch, before the exporter changed anything:That
PASSwent over SNMPv3 —--dry-runshowsshiva … v3 SNMP_AUTHPASS_ILO SNMP_PRIVPASS_ILO.Then the repository
auth_ilois the authPriv block;snmp.yamlregenerated from it (1787 → 1787 metrics, five placeholders survive).render-config.sh'sREQUIREDarray and the example secrets file carry the two passphrase keys in place of the community; the sops file does the same in its own commit.security.md,hardware.md). The SNMPv1 switch-off is not claimed yet — that is §4.5, aftermake render && make reloadfrom the main checkout, and it is proved with--oldand recorded on Move the iLO and the UPS card to SNMPv3 authPriv (ADR-0036) #85.What the first real pass found
#431 dry-ran the v3 block shape with every device still on v2c, so it could not see this: the generator fills every unset auth field from its defaults, and its default community is the stock string. A v3 block with no community line comes out of
make snmp-generatecarrying that string beside the USM user — and gitleaks' community rule, correctly, failedmake validateon the generated file. An explicit empty string is marshalled with omitempty and the line is dropped. So:snmp-targets.sh --checknow requirescommunity: ""in a v3 block and refuses anything else (negative-tested against a copy of the generator with the line removed).Verified
snmp.yamlbyte for byte.scripts/snmp-targets.sh --check,--dry-run, yamllint on the generator, gitleaks (pinned image, working tree) clean.scripts/validate.shgreen except the gitleaks finding above, which the rewording removed.snmp-verify.sh --device shivaas pasted.After merge
From the main checkout:
make render && make reload;up{job="snmp",instance="10.0.30.10"}back to 1. Then §4.5 on the iLO and--old, by hand.🤖 Generated with Claude Code